Defensive improvements to ACL instructions for inattentive users. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent copy-pasting with undefined ${USER2} variable by using
POSIX shell parameter expansion feature "${parameter:?word}", which
prints an error "word" if $parameter is empty or undefined.
In the context of setfacl user:${USER2}:x, an empty string is
legal and indicates "the owner, whoever that is". More than one
user has removed their own permissions by setfacl'ing themselves
out of them accidentally. It's time to put a safety on this
foot-gun.
Also move a note from Step 3 to below Step 4 in order to make
Step 4 more prominent and less easily-skipped by those in a
hurry.
btravouillon
approved these changes
Jun 21, 2024
lebrice
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent copy-pasting with undefined
${USER2}variable by using POSIX shell parameter expansion feature "${parameter:?word}", which prints an error "word" if$parameteris empty or undefined.In the context of
setfacl [-args] user:${USER2}:x, an empty string is legal and indicates "the owner, whoever that is". More than one user has removed their own permissions bysetfacl'ing themselves out of them accidentally. It's time to put a safety on this foot-gun.Also move a note from Step 3 to below Step 4 in order to make Step 4 more prominent and less easily-skipped by those in a hurry.