Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-39
to
+68
|
|
||
| # Compute the change to make | ||
| delta = crc ^ newcrc | ||
| delta = multiply_mod(reciprocal_mod(pow_mod(2, (length - offset) * 8)), delta) | ||
|
|
||
| # Patch 4 bytes in the buffer | ||
| bytes4 = bytearray(buffer[offset:offset+4]) | ||
| if len(bytes4) != 4: | ||
| raise IOError("Cannot read 4 bytes at offset") | ||
|
|
||
| if printstatus: | ||
| print("Target bytes @ offset: {:s}".format(str(bytes4).encode('hex'))) | ||
|
|
||
| for i in range(4): | ||
| bytes4[i] ^= (reverse32(delta) >> (i * 8)) & 0xFF | ||
|
|
||
| if printstatus: | ||
| print("Patched value: {:s}".format(str(bytes4).encode('hex'))) | ||
|
|
||
| result = str(buffer[0:offset] + bytes4 + buffer[offset+4:]) | ||
| result = str(buffer[:offset] + bytes4 + buffer[offset+4:]) | ||
|
|
||
| if printstatus: | ||
| print("Computed and wrote patch") | ||
|
|
||
| # Recheck entire file | ||
| if get_buffer_crc32(result) != newcrc: | ||
| raise AssertionError("Failed to update CRC-32 to desired value") | ||
| elif printstatus: | ||
| print("New CRC-32 successfully verified") | ||
|
|
There was a problem hiding this comment.
Function modify_buffer_crc32 refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
| for i in range(32): | ||
| for _ in range(32): |
There was a problem hiding this comment.
Function reverse32 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| buffer = buffer[0:8] + pack('<Q', bad_ptr) | ||
| buffer = buffer[:8] + pack('<Q', bad_ptr) |
There was a problem hiding this comment.
Lines 60-60 refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!