Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement cleanup phase #623

Closed
wants to merge 1 commit into from
Closed

feat(core): implement cleanup phase #623

wants to merge 1 commit into from

Conversation

nfantone
Copy link
Contributor

@nfantone nfantone commented Mar 4, 2021 •
edited
Loading

What does this implement/fix? Explain your changes.

Adds a new cleanup phase that executes middlewares regardless of whether an error was thrown or not.

Does this close any currently open issues?

Solves #622.

Where has this been tested?

Node.js Versions: v14.15.5

Middy Versions: 2.0.0-alpha.5

AWS SDK Versions: 2.856.0

Todo list

  • Feature/Fix fully implemented
  • Added tests
  • Updated relevant documentation
  • Updated relevant examples

@nfantone nfantone mentioned this pull request Mar 4, 2021
Closed
@KillDozerX2
Copy link
Contributor

This is embarrasing but I was just reviewing one of my subordinates PR and approved this absent-mindedly, Please ignore

@willfarrell
Copy link
Member

Now that onError is now reversed, cleanup is no longer needed. See release/3.x branch for implementation.

@willfarrell willfarrell closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillDozerX2 KillDozerX2 KillDozerX2 approved these changes

Assignees
No one assigned
Labels
breaking change core enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfantone @KillDozerX2 @willfarrell