Refactor core type generics naming #592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat a WIP still. It would be good to come up with a way to test type definitions more thoroughly though. One option is to move some (or all) of the test files to TypeScript and that will naturally catch some potential breaking changes in future PRs.
I found the use of the
EventType
andHandlerReturnType
definitions to be confusing as I was working on this. I think they can be simplified or removed entirely, but I'm going to mull over their purpose a bit. Would appreciate input on what they are meant to do as I did not find a need for such a construct in working on my own framework https://github.com/ShallotJS/shallot/blob/4781b6700e637d1e15dedf99d5202ddd799888b8/src/aws/index.ts#L44-L52What does this implement/fix? Explain your changes.
any
withunknown
https://stackoverflow.com/questions/51439843/unknown-vs-anyDoes this close any currently open issues?
#585 (comment)
Todo list
[ ] Feature/Fix fully implemented
[ ] Added tests
[ ] Updated relevant documentation
[ ] Updated relevant examples