Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Add comment sorting configuration #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

josephsnyder
Copy link

Add the capability to sort the Midas comments to show most recent first
or oldest first. A simple select will determine the sorting order of the
comments as they are retrieved from the database (ASC vs DESC).

Add the capability to sort the Midas comments to show most recent first
or oldest first.  A simple select will determine the sorting order of the
comments as they are retrieved from the database (ASC vs DESC).
define("OLDEST_FIRST",0);
define("NEWEST_FIRST",1);

?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete closing tag and extra newline.

@josephsnyder
Copy link
Author

Thanks for the comments Jamie. I'll get to work on them.

RE: 'Admin' vs 'Config' controller: I was pointed to this page when I asked about the module configuration: https://www.kitware.com/midaswiki/index.php/Documentation/3.2.14/Developer/Modules#Defining_an_editable_configuration_for_your_module

@cpatrick
Copy link
Contributor

@josephsnyder Who'd you ask? 😃 We are phasing out the wiki in favor of RTD.

@josephsnyder
Copy link
Author

Charles M. (Not trying to throw him under the bus)

@jcfr
Copy link
Contributor

jcfr commented Sep 18, 2015

@cpatrick Good to transition to RTD.

Would it be possible to add a big red note at the top of every midas wiki page mentioning that the doc is not maintained anymore. And pointing to the new doc ? Or something similar to this.

This could be done easily by:

  • creating a mediawiki template named for example: disclaimer
  • updating every page with mwclient python module and prepending {{:disclaimer}}

@josephsnyder
Copy link
Author

That would definitely make sense. The only issue is the RTD (http://midas-server.readthedocs.org/en/latest/) doesn't have this information yet. It seems to only consist of the installation information, which is why I was pointed to the Wiki

@jamiesnape
Copy link
Contributor

No developer documentation yet, unfortunately. Create an issue and assign it to me and eventually it will appear.

@josephsnyder
Copy link
Author

Will do.

Move from "Config" controllers to "Admin" controllers.
Move from "generic Forms" to a ZEND form.
Fix all filesfor style.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants