This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Addition of <publisher>.<extension-id> to configuration ID sample #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration contribution's "targets" array According to the [Hello World with Configuration](https://docs.microsoft.com/en-us/azure/devops/extend/develop/add-dashboard-widget?view=vsts#step-5-extension-manifest-updates-1) sample extension widget, the array of targets for the widget needs to contain the ID for the configuration in the form <publisher>.<extension-id>.<configuration-id>, which in the case of the sample would be `fabrikam.vsts-extensions-myExtensions.HelloWorldWidget.Configuration` However the sample source code [here](https://github.com/Microsoft/vsts-extension-samples/blob/master/widgets/vss-extension.json) appears not to following this ID naming convention. The vss-extension.json file currently contains ` "targets": [ "ms.vss-dashboards-web.widget-catalog", ".HelloWorldWidget.Configuration" ], ` but I suspect it should contain the following ` "targets": [ "ms.vss-dashboards-web.widget-catalog", "fabrikam.vsts-extensions-myExtensions.HelloWorldWidget.Configuration" ], `
|
Well, it doesn't exactly say you need to always do that, what it says is if you want it to support Configuration, then you have to do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Hello World with Configuration sample extension widget, the array of targets for the widget needs to contain the ID for the configuration in the form .., which in the case of the sample would be
fabrikam.vsts-extensions-myExtensions.HelloWorldWidget.ConfigurationHowever the sample source code here appears not to following this ID naming convention.
The vss-extension.json file currently contains
"targets": [ "ms.vss-dashboards-web.widget-catalog", ".HelloWorldWidget.Configuration" ],but I suspect it should contain the following
"targets": [ "ms.vss-dashboards-web.widget-catalog", "fabrikam.vsts-extensions-myExtensions.HelloWorldWidget.Configuration" ],