-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vowpal-wabbit] New port #27323
Merged
BillyONeal
merged 15 commits into
microsoft:master
from
jackgerrits:add_vowpalwabbit_port
Oct 24, 2022
Merged
[vowpal-wabbit] New port #27323
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
28230a1
add vowpalwabbit port
jackgerrits f3d44f2
update baseline
jackgerrits c1271ce
update version
jackgerrits 20760f7
update baseline after version change
jackgerrits e2acef4
mark arm64-windows as fail
jackgerrits c007269
Update vowpalwabbit.json
jackgerrits f577c3a
Update ci.baseline.txt
jackgerrits 27208a7
Update ci.baseline.txt
jackgerrits 684ba5b
update supports field in manifest
jackgerrits 074871b
run x-add-version
jackgerrits 9dba96d
Update ci.baseline.txt
LilyWangLL 9b6894c
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal 64f2791
Add usage and nitpick quotes.
BillyONeal 10b9efb
rename port to vowpal-wabbit and add patch to remove bin targets
jackgerrits 427e96d
update versions, rename port
jackgerrits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
|
||
vcpkg_from_github( | ||
OUT_SOURCE_PATH SOURCE_PATH | ||
REPO VowpalWabbit/vowpal_wabbit | ||
REF 9496a6dd5610910a495ca004a93c8ab6913293e4 | ||
SHA512 df4da3f3ab763dbd113b0ace0552d676ec905a6ff0d942d9fc1828e36fb8440d1b75a61c1ea6de09879e0f52547366936d02a77dba2bac89503a075da12414db | ||
HEAD_REF master | ||
) | ||
|
||
vcpkg_cmake_configure( | ||
SOURCE_PATH ${SOURCE_PATH} | ||
OPTIONS | ||
-DVW_INSTALL=ON | ||
-DRAPIDJSON_SYS_DEP=ON | ||
-DFMT_SYS_DEP=ON | ||
-DSPDLOG_SYS_DEP=ON | ||
-DVW_BOOST_MATH_SYS_DEP=ON | ||
-DVW_ZLIB_SYS_DEP=ON | ||
-DVW_BUILD_VW_C_WRAPPER=OFF | ||
-DBUILD_TESTING=OFF | ||
) | ||
vcpkg_cmake_install() | ||
|
||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
|
||
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) | ||
|
||
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/VowpalWabbit/) | ||
|
||
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin") | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"name": "vowpalwabbit", | ||
"version": "9.5.0", | ||
"description": "Reduction based online learning framework with a focus on contextual bandits and reinforcement learning.", | ||
"homepage": "https://github.com/vowpalwabbit/vowpal_wabbit", | ||
"license": "BSD-3-Clause", | ||
"dependencies": [ | ||
"boost-math", | ||
"flatbuffers", | ||
"fmt", | ||
"rapidjson", | ||
"spdlog", | ||
"string-view-lite", | ||
{ | ||
"name": "vcpkg-cmake", | ||
"host": true | ||
}, | ||
{ | ||
"name": "vcpkg-cmake-config", | ||
"host": true | ||
}, | ||
"zlib" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1132,6 +1132,8 @@ v8:x64-osx=fail | |
v8:x64-uwp=fail | ||
vectorclass:arm64-windows=fail | ||
vectorclass:arm-uwp=fail | ||
vowpalwabbit:arm64-windows=fail | ||
vowpalwabbit:x86-windows=fail | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this port doesn't support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated |
||
vulkan:arm64-windows=fail | ||
vulkan:arm-uwp=fail | ||
vulkan:x64-linux=fail | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"versions": [ | ||
{ | ||
"git-tree": "6b1205a5160128a40adf6714c5f9d6a38eaf1383", | ||
"version": "9.5.0", | ||
"port-version": 0 | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are build error when build
vowpalwabbit:arm64-windows
, this port doesn't supportarm64
too.C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.33.31629\include\xmmintrin.h(27): fatal error C1189: #error: This header is specific to X86, X64 and ARM64EC targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked arm+windows unsupported