-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Symbol refactor - DO NOT REVIEW #4849
base: main
Are you sure you want to change the base?
Conversation
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
You can try these changes here
|
…bol-refactor-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check: lsp seems to have some reload issue
const stdTypes: Partial<StdTypes> = {}; | ||
const symbolLinks = new Map<number, SymbolLinks>(); | ||
const mergedSymbols = new Map<Sym, Sym>(); | ||
const docFromCommentForSym = new Map<Sym, string>(); | ||
const augmentDecoratorsForSym = new Map<Sym, AugmentDecoratorStatementNode[]>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could move this whole resolution into the name resolver + consider renaming it to linker
Taking over this pr #2640 just creating for diff purpose for now