some accessibilty changes #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rishikesh-microsoft
commented
May 30, 2022
Rishikesh-microsoft
commented
- Added asterisk symbol for Start and End Date field in DateTimepicker component.
- Made save button disabled color as grey color important when input is empty
- Changed to a convenient aria-label for zoom-in and zoom-out button AvailabilityChart component.
- Changed background color for removing Keros related issues in error messages in DateTimepicker component.
- Added role as alert for alert messages in DateTimepicker component..
- Added new string constants for asterisk and alert messages in String.ts file.
|
|
| @@ -547,6 +549,9 @@ class DateTimePicker extends ChartComponent{ | |||
| .attr('for', inputID) | |||
| .attr('aria-label', `${startOrEnd === 'start' ? this.getString('Start time input') : this.getString('End time input')}`) | |||
| .text(this.getString(startOrEnd)); | |||
| let timeRequired = timeLabel.append("span") | |||
There was a problem hiding this comment.
I see you've declared the variable timeRequired here, where are you using it?
There was a problem hiding this comment.
I have removed the timeRequired variable in my next commit.
thomasricci
reviewed
Jun 2, 2022
| @@ -77,9 +77,12 @@ class Strings { | |||
| "timezone selection": "timezone selection", | |||
| "Start time input": "Start time input", | |||
| "End time input": "End time input", | |||
| "*": "*", | |||
| "snap end time to latest": "snap end time to latest", | |||
| "zoom in": "zoom in", | |||
| "zoom out": "zoom out", | |||
There was a problem hiding this comment.
Do you still need these "zoom in" "zoom out"?
There was a problem hiding this comment.
We need this as it is used in title attribute.
|
Do you need to update the library version too ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.