Suppress SYSLIB0057 in tests #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
added
the
Type: Infrastructure
benjaminpetit
approved these changes
Aug 27, 2024
MihaZupan
merged commit 2b50e20
into
microsoft:darc-main-008c2f5b-a6b3-4f2c-a1a9-34f34edab463
6 checks passed
dotnet-maestro bot
added a commit
that referenced
this pull request
Aug 27, 2024
[main] Update dependencies from dotnet/arcade - Suppress SYSLIB0057 in tests (#2585)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build failure in #2579
https://learn.microsoft.com/en-gb/dotnet/fundamentals/syslib-diagnostics/syslib0057 suggests new ways to load certs, which are only available with .NET 9.
Since we can't use that yet on older platforms, I'm just suppressing the analyzer in our tests.