Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that MaxRequestBodySize only applies to the forwarder #2584

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Document that MaxRequestBodySize only applies to the forwarder #2584

merged 1 commit into from
Aug 27, 2024

Conversation

MihaZupan
Copy link
Member

Documents #2533 (comment)

The MaxRequestBodySize set via YARP configuration applies to the request as it's being processed by YARP. It does not apply in any previous middleware you set during MapReverseProxy.
In your case, if you already read the whole body before a limit has been set, it won't be enforced later on since you're not reading from the request anymore (just from the already-buffered copy).

@MihaZupan MihaZupan added the Type: Documentation Improvements or additions to documentation label Aug 27, 2024
@MihaZupan MihaZupan added this to the YARP 2.2 milestone Aug 27, 2024
@karelz karelz mentioned this pull request Aug 27, 2024
Closed
@MihaZupan MihaZupan merged commit ddf5c1b into microsoft:main Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpetit benjaminpetit benjaminpetit approved these changes

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
YARP 2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaZupan @benjaminpetit