Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match music play hints with toolbox blocks in 'V2 Hamster' #5961

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

ganicke
Copy link
Collaborator

@ganicke ganicke commented Sep 18, 2024

The play() function in the hints is mismatched with _playDefaultBackground() from the toolbox blocks causing code validation to fail for valid blocks. The play() functions in the hints are changed to match.

Closes #5940
Closes #5967

Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...good find! We may need to look into whether or not we actually ought to be decompiling into this function, but that's a different issue. For now, this seems like a good fix to me!

@ganicke ganicke merged commit 1226ac8 into master Sep 20, 2024
6 checks passed
@ganicke ganicke deleted the sound-block-validation branch September 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial code checker not working for Pet Hamster Incorrect Code Validation Error in Hamster Tutorial
2 participants