Remove RNG seed call in platform_init(). #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not needed, as the random number generator is already seeded in uBit.init(). This also works around this issue until it is resolved in DAL & CODAL: #5409 Apart from that it is a costly call, specially in V1 where it takes 50 microsec or more, and in theory can take up to 480 us.
|
Using the testing deployement : Creating a new project, adding the Bluetooth extension and this code: basic.showNumber(randint(0, 9))
basic.forever(function () {
})And it shows that it does resolve: |
mmoskal
approved these changes
Sep 13, 2024
abchatra
pushed a commit
that referenced
this pull request
Sep 23, 2024
It is not needed, as the random number generator is already seeded in uBit.init(). This also works around this issue until it is resolved in DAL & CODAL: #5409 Apart from that it is a costly call, specially in V1 where it takes 50 microsec or more, and in theory can take up to 480 us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call is not needed, as the random number generator is already seeded in uBit.init().
This also resolves/works-around this issue (more info in #5409 (comment)), which might take a while before we fix it in DAL:
Apart from that, this is a costly call, specially in V1 where it takes 50 microsec or more, and in theory could take up to 480 us.