Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove youtubeid in jacdac gallery #4799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove youtubeid in jacdac gallery #4799

wants to merge 1 commit into from

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jul 7, 2022 •
edited
Loading

The gallery item has a url and a youtubeid, pxt gets confused and renders a "play video" button that points to the URL. This feels like a regression (can we have a video + a project link?) but it's probably not worth a hot patch.

You can test the current broken behavior in makecode.microbit.org

image

@pelikhan pelikhan requested review from abchatra and riknoll July 7, 2022 04:02
jwunderl
jwunderl approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jwunderl jwunderl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc the default button behavior got to be too much and someone swapped it so that it'd only be one button by default w/ anything more handled by setting the otherActions field for extra buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwunderl jwunderl jwunderl approved these changes

@abchatra abchatra Awaiting requested review from abchatra

@riknoll riknoll Awaiting requested review from riknoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelikhan @jwunderl