[Mobile] Add E2E BrowserStack tests for iOS tests #22610
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | ||
| formatted_plist = plist_file_content.format(team_id = team_id, provisioning_profile_uuid = provisioning_profile_uuid) | ||
|
|
||
| with open(args.dest_file, 'w') as file: | ||
| file.write(formatted_plist) |
There was a problem hiding this comment.
| provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | |
| formatted_plist = plist_file_content.format(team_id = team_id, provisioning_profile_uuid = provisioning_profile_uuid) | |
| with open(args.dest_file, 'w') as file: | |
| file.write(formatted_plist) | |
| provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | |
| formatted_plist = plist_file_content.format(team_id=team_id, provisioning_profile_uuid=provisioning_profile_uuid) | |
| with open(args.dest_file, "w") as file: | |
| file.write(formatted_plist) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,41 @@ | |||
| import argparse | |||
Check warning
Code scanning / lintrunner
BLACK-ISORT/format Warning
|
Working mac packaging pipeline run Working android packaging pipeline run |
|
|
||
| # Use script step because exporting the .ipa file using the Xcode@5 task was too brittle (Xcode@5 is designed | ||
| # to handle both the .xcarchive step and the .ipa step in the same step -- ran into countless issues with signing | ||
| # and the .plist file) |
There was a problem hiding this comment.
I'm completely fine with directly calling xcodebuild in script steps. the Xcode steps seem to add extra complexity.
do you think it would be simpler to directly run the corresponding xcodebuild commands from the other Xcode steps too?
| workingDirectory: '$(Build.BinariesDirectory)/app_center_test/apple_package_test/' | ||
| displayName: "Create .ipa file" | ||
| env: | ||
| DEVELOPER_DIR: /Applications/Xcode_${{ variables.xcodeVersion }}.app/Contents/Developer |
There was a problem hiding this comment.
do we need to set DEVELOPER_DIR here? there's a call to xcode-select in the earlier use-xcode-version.yml step
| <string>{team_id}</string> | ||
| <key>provisioningProfiles</key> | ||
| <dict> | ||
| <key>ai.onnxruntime.tests.ios-package-test</key> |
There was a problem hiding this comment.
this is a pretty specific plist file, right? maybe put the script together with the other ios package test files? and consider a more specific name like generate_export_options_plist.py
| team_id = os.environ["APPLE_TEAM_ID"] | ||
| provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] |
There was a problem hiding this comment.
nit: unless these are secret, I'd prefer using command line options for them.
| "Path to the test APK. " | ||
| "Typically, the test APK is in " |
There was a problem hiding this comment.
this help text still refers to APK
Description
Motivation and Context
Misc info
Additional build steps were required to get the necessary testing artifacts for BrowserStack. App Center consumed an entire folder, while BrowserStack requests the following:
Flow
Here is a rough outline of what is happening in the pipeline: