-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Add E2E BrowserStack tests for iOS tests #22610
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | ||
formatted_plist = plist_file_content.format(team_id = team_id, provisioning_profile_uuid = provisioning_profile_uuid) | ||
|
||
with open(args.dest_file, 'w') as file: | ||
file.write(formatted_plist) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | |
formatted_plist = plist_file_content.format(team_id = team_id, provisioning_profile_uuid = provisioning_profile_uuid) | |
with open(args.dest_file, 'w') as file: | |
file.write(formatted_plist) | |
provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] | |
formatted_plist = plist_file_content.format(team_id=team_id, provisioning_profile_uuid=provisioning_profile_uuid) | |
with open(args.dest_file, "w") as file: | |
file.write(formatted_plist) |
Working mac packaging pipeline run Working android packaging pipeline run |
|
||
# Use script step because exporting the .ipa file using the Xcode@5 task was too brittle (Xcode@5 is designed | ||
# to handle both the .xcarchive step and the .ipa step in the same step -- ran into countless issues with signing | ||
# and the .plist file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm completely fine with directly calling xcodebuild in script steps. the Xcode steps seem to add extra complexity.
do you think it would be simpler to directly run the corresponding xcodebuild commands from the other Xcode steps too?
workingDirectory: '$(Build.BinariesDirectory)/app_center_test/apple_package_test/' | ||
displayName: "Create .ipa file" | ||
env: | ||
DEVELOPER_DIR: /Applications/Xcode_${{ variables.xcodeVersion }}.app/Contents/Developer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to set DEVELOPER_DIR here? there's a call to xcode-select in the earlier use-xcode-version.yml step
<string>{team_id}</string> | ||
<key>provisioningProfiles</key> | ||
<dict> | ||
<key>ai.onnxruntime.tests.ios-package-test</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a pretty specific plist file, right? maybe put the script together with the other ios package test files? and consider a more specific name like generate_export_options_plist.py
team_id = os.environ["APPLE_TEAM_ID"] | ||
provisioning_profile_uuid = os.environ["PROVISIONING_PROFILE_UUID"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unless these are secret, I'd prefer using command line options for them.
"Path to the test APK. " | ||
"Typically, the test APK is in " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this help text still refers to APK
Description
Motivation and Context
Misc info
Additional build steps were required to get the necessary testing artifacts for BrowserStack. App Center consumed an entire folder, while BrowserStack requests the following:
Flow
Here is a rough outline of what is happening in the pipeline: