Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven Sha256 Checksum Issue #22599

Closed
wants to merge 1 commit into from
Closed

Conversation

idiskyle
Copy link
Contributor

Description

Changes applied to maven related signing:

  • Windows sha256 file encoded by utf8(no BOM)
  • powershell script task used latest version, previous 5.1 version only supports utf8 with BOM.
  • Windows sha256 file content in format 'sha256value *filename.extension'.
  • Linux sha256 file content in format 'sha256value *filename.extension'.

More information about powershell encoding:
Windows powershell encoding reference: about_Character_Encoding - PowerShell | Microsoft Learn

  • for version 5.1, it only has 'UTF8 Uses UTF-8 (with BOM).'
  • for version v7.1 and higher, it has:
    utf8: Encodes in UTF-8 format (no BOM).
    utf8BOM: Encodes in UTF-8 format with Byte Order Mark (BOM)
    utf8NoBOM: Encodes in UTF-8 format without Byte Order Mark (BOM)

Motivation and Context

@idiskyle idiskyle requested a review from a team as a code owner October 25, 2024 08:20
@idiskyle idiskyle closed this Oct 25, 2024
@snnn snnn deleted the zhanxi/fix_maven_checksum branch October 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant