Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSEP/WebGPU] Fix data causing output mismatch resulting in CI build failures occasionally #22596

Merged
merged 6 commits into from
Oct 26, 2024

Conversation

satyajandhyala
Copy link
Contributor

Description

Test case failing sometimes and passing other times.

Motivation and Context

Prevent unnecessary CI build failures requiring manually rerunning tests

@satyajandhyala satyajandhyala marked this pull request as ready for review October 25, 2024 04:34
@satyajandhyala satyajandhyala changed the title [JSEP/WebGPU] Fix data causing flakey output mismatch resulting in CI build failures [JSEP/WebGPU] Fix data causing output mismatch resulting in CI build failures occasionally Oct 25, 2024
@fs-eire
Copy link
Contributor

fs-eire commented Oct 25, 2024

Will it still cause random test failure if not modify the test data?

@satyajandhyala
Copy link
Contributor Author

Will it still cause random test failure if not modify the test data?

Yes.

@fs-eire fs-eire merged commit 05fbb43 into main Oct 26, 2024
62 checks passed
@fs-eire fs-eire deleted the sajandhy/webgpu_fix_gqa_test_data branch October 26, 2024 08:37
@fs-eire
Copy link
Contributor

fs-eire commented Oct 26, 2024

Merge this PR to unblock the pipeline. Should re-enable the commented out test case once the root cause is identified and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants