allow setting runtime handles (alternative) #1002
Merged
+172
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative way of #997 to implement allowing users to set runtime handles.
The basic idea is to create a JSON string representing the
Config
class from theRuntimeSettings
, and theConfig
class will merge them.Currently this PR is not working because of the following:
The existing JSON parser does not support multiple entries in
provider_options
The following JSON will fail to parse.
When trying to specify JSON overlay, two "webgpu" items does not merge.
genai_config.json:
generated overlay config:
Result:
This PR depends on a code change to the Config class to support the expected parsing behaviors.