Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webfont -> svgtofont #597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

webfont -> svgtofont #597

wants to merge 2 commits into from

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jul 31, 2024

  • A new SVG file named icon.svg is added under the packages/vscode/font directory. It appears to contain a single SVG path, which could possibly be used as an icon or logo.
  • Some changes were made to the .vscodeignore file which likely determine what files or directories are ignored by VSCode.
    • Added font/* which means all files in the font directory will be ignored.
    • Additional built file types are now ignored as well: .woff2, .ttf, .extension and .symbol.svg.
  • Updates are made to the updatefonts.mjs file:
    • The dependency webfont is being replaced by svgtofont, as seen in the changes in the package.json file.
    • The function generateFont() has been updated to reflect the usage of the new library, svgtofont.
    • The function now appears to generate a complete font set from SVG files in the font directory instead of just an array of SVGs.
    • There's no longer a need to manually write the output to a file as svgtofont handles it internally.
  • package.json has seen some changes as well - the webfont has been removed entirely and svgtofont has been added. This suggests a migration from the webfont library to the svgtofont library for font generation.

Overall, these changes seem to streamline the process of generating fonts from SVG files in the codebase.

generated by pr-describe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant