Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Privacy Guard unit test failures #1304

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix Privacy Guard unit test failures #1304

merged 2 commits into from
Oct 7, 2024

Conversation

zgzjhzxhq
Copy link
Contributor

This change fixes Privacy Guard related unit test and functional test failures.

  1. one unit test failure that fails 1/3 of the time due to a probabilistic issue.
  2. one unit test failure due to test code out of date with production code
  3. one functional test failure due to test code out of date with production code.

They were not discovered earlier because some of the test cases are not run in 1DS C++ SDK main repo build pipelines - privacy guard is in submodule repo, so main repo does not compile them along with public SDK files, hence some unit tests are disabled using a macro.

I discussed with Lalit and the agreement we settled is that developers need to run all unit test locally before submitting PR for review. I also modified our developers guide to include this in Privacy Guard team guide.

@zgzjhzxhq zgzjhzxhq requested a review from a team as a code owner October 7, 2024 21:13
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb
Copy link
Contributor

lalitb commented Oct 7, 2024

MacOS CI tests are not running for #1299, we should be good to force merge to unblock privacy guard CI.

@lalitb lalitb merged commit 4166724 into main Oct 7, 2024
19 of 24 checks passed
@lalitb lalitb deleted the user/ycw/pg/fixtests branch October 7, 2024 23:48
@ThomsonTan
Copy link
Contributor

Does this apply to the privacy guard module, or all modules for cpp_client_telemetry?

the agreement we settled is that developers need to run all unit test locally before submitting PR for review.

@zgzjhzxhq
Copy link
Contributor Author

Does this apply to the privacy guard module, or all modules for cpp_client_telemetry?

the agreement we settled is that developers need to run all unit test locally before submitting PR for review.

It is for the privacy guard module in 1DS C++ SDK only. Similar situation may apply to other components in the *_modules repo, though, it's up to them whether they want to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants