fix file backend pushinfo retrieval #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natewalck
approved these changes
Jul 8, 2024
| // | ||
| // If an ID does not exist or is not enrolled properly then | ||
| // implementations should silently skip returning any push data for | ||
| // them. It is up to the caller to discern any missing IDs from the |
There was a problem hiding this comment.
How would one discern this is the case? Does this make it more obvious or less obvious what is going in from the consumer perspective?
There was a problem hiding this comment.
The caller would need to compare the input set of IDs to the returned (output) set of IDs to see what's missing or different. This is how the MySQL backend works, fwiw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file storage backend was returning an error when retrieving push info from a non-existent or improperly enrolled device (i.e. missing
TokenUpdatemessage). However given that the push info retriever shouldn't error for a single enrollment like that (in case there are multiple) we now mask that error. Also add a regression test for this.