clear bootstrap tokens on Authenticate message. add regression test f…

…or re-enrollment. fixes part of #71

storage/file/file.go

@@ -166,6 +166,14 @@ func (s *FileStorage) StoreAuthenticate(r *mdm.Request, msg *mdm.Authenticate) e
 			return err
 		}
 	}
+	if err := e.resetNumericFile(TokenUpdateTallyFilename); err != nil {
+		return err
+	}
+	// remove the BootstrapToken when we receive an Authenticate message
+	// BS tokens are only valid when a new one is escrowed after enrollment.
+	if err := os.Remove(e.dirPrefix(BootstrapTokenFile)); err != nil && !errors.Is(err, os.ErrNotExist) {
+		return err
+	}
 	return e.writeFile(AuthenticateFilename, []byte(msg.Raw))
 }
 
@@ -229,9 +237,6 @@ func (s *FileStorage) Disable(r *mdm.Request) error {
 		if err := e.writeFile(DisabledFilename, nil); err != nil {
 			return err
 		}
-		if err := e.resetNumericFile(TokenUpdateTallyFilename); err != nil {
-			return err
-		}
 	}
 	return e.removeSubEnrollments()
 }

storage/mysql/mysql.go

@@ -109,6 +109,8 @@ ON DUPLICATE KEY
 UPDATE
     identity_cert = new.identity_cert,
     serial_number = new.serial_number,
+    bootstrap_token_b64 = NULL,
+    bootstrap_token_at = NULL,
     authenticate = new.authenticate,
     authenticate_at = CURRENT_TIMESTAMP;`,
 		r.ID, pemCert, nullEmptyString(msg.SerialNumber), msg.Raw,

storage/pgsql/postgresql.go

@@ -109,6 +109,8 @@ ON CONFLICT ON CONSTRAINT devices_pkey DO
 UPDATE SET
     identity_cert = EXCLUDED.identity_cert,
     serial_number = EXCLUDED.serial_number,
+    bootstrap_token_b64 = NULL,
+    bootstrap_token_at = NULL,
     authenticate = EXCLUDED.authenticate,
     authenticate_at = CURRENT_TIMESTAMP;`,
 		r.ID, nullEmptyString(string(pemCert)), nullEmptyString(msg.SerialNumber), msg.Raw,

test/e2e/bstoken.go

@@ -26,7 +26,7 @@ func bstoken(t *testing.T, ctx context.Context, d bstokenDevice) {
 	}
 
 	if tok != nil {
-		t.Errorf("token for supposedly new device %s was not nil", d.ID())
+		t.Errorf("token for supposedly freshly enrolled device %s was not nil", d.ID())
 	}
 
 	input := []byte("hello world")

test/e2e/e2e.go

@@ -2,6 +2,7 @@ package e2e
 
 import (
 	"context"
+	"fmt"
 	"net/http"
 	"testing"
 
@@ -93,6 +94,18 @@ func TestE2E(t *testing.T, ctx context.Context, store storage.AllStorage) {
 
 	t.Run("bstoken", func(t *testing.T) { bstoken(t, ctx, d.Enrollment) })
 
+	// re-enroll device
+	// this is to try and catch any leftover crud that a storage backend didn't
+	// clean up (like the tally count, BS token, etc.)
+	err = d.DoEnroll(ctx)
+	if err != nil {
+		t.Fatal(fmt.Errorf("re-enrolling device %s: %w", d.ID(), err))
+	}
+
+	t.Run("tally-after-reenroll", func(t *testing.T) { tally(t, ctx, d, store, 1) })
+
+	t.Run("bstoken-after-reenroll", func(t *testing.T) { bstoken(t, ctx, d.Enrollment) })
+
 	err = store.ClearQueue(d.NewMDMRequest(ctx))
 	if err != nil {
 		t.Fatal()

test/enrollment/enrollment.go

@@ -191,15 +191,15 @@ func (e *Enrollment) doTokenUpdate(ctx context.Context) error {
 	return HTTPErrors(resp)
 }
 
-// DoEnroll enrolls this enrollment into MDM.
+// DoEnroll enrolls (or re-enrolls) this enrollment into MDM.
 // Authenticate and TokenUpdate check-in messages are sent via the
 // transport to the MDM server.
 func (e *Enrollment) DoEnroll(ctx context.Context) error {
 	e.enrollM.Lock()
 	defer e.enrollM.Unlock()
 
 	if e.enrolled {
-		return ErrAlreadyEnrolled
+		e.enrolled = false
 	}
 
 	// generate Authenticate check-in message