-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal fix for rworkflow bug #540
Conversation
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Bumping r version for Mac workflow tends to work. I think the same for Ubuntu at least, until the fix in |
Alright, maybe we could go like this as a temporary fix. Can you fix estimateDiversity.R in this PR (change the title also according to that) |
Signed-off-by: Daena Rys <[email protected]>
Roxygen2 changed how list is created. It seems that it throws now a warning. This is related to this issue: #532 Check the workflow run, you will see these warnings:
Can you fix them? See for example from here how lists are now created |
Signed-off-by: Daena Rys <[email protected]>
@TuomasBorman I think we can finalize this now. Unless, you have more changes in mind |
Looks good, but still not working. Update manual pages, let's see if that works |
I updated man pages already. The fail is as at the stage of deployment. Something about the bot not having permission to deploy to the repo. See log here |
Signed-off-by: Daena Rys <[email protected]>
Now there is another error. Can you remove the rworkflows file and then create a new one with rworkflows::use_workflow(). That should update the workflow. Remember to specify R version to 4.4.0 (auto seems not to work) In the future, create branch directly to mia. It is simpler since then I can also contribute much easier. |
Signed-off-by: Daena Rys <[email protected]>
Try to put R back to auto. It should work |
Signed-off-by: Daena Rys <[email protected]>
From the rworkflows issue
Can you try that fix? |
Signed-off-by: Daena Rys <[email protected]>
Yeah, I tried this. Still failing. I think the issue here is permission to microbiome/mia.git is denied to github-actions[bot]. I'm not quite sure but did we alter the secrets? |
Signed-off-by: Daena Rys <[email protected]>
This reverts commit e739d6e.
Yes, I noticed that too. However, nothing should have changed. I will check |
Signed-off-by: Daena Rys <[email protected]>
This commit provides a temporal fix to rworkflow by bumping the r version of MacOS and Ubuntu and
fixing a bug in R/estimateDiversity.R.