Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal fix for rworkflow bug #540

Merged
merged 13 commits into from
May 14, 2024

Conversation

Daenarys8
Copy link
Collaborator

@Daenarys8 Daenarys8 commented May 8, 2024

This commit provides a temporal fix to rworkflow by bumping the r version of MacOS and Ubuntu and
fixing a bug in R/estimateDiversity.R.

Daenarys8 and others added 6 commits May 8, 2024 17:40
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Collaborator Author

Bumping r version for Mac workflow tends to work. I think the same for Ubuntu at least, until the fix in
R/estimateDiversity.R is merged.

@TuomasBorman
Copy link
Contributor

Alright, maybe we could go like this as a temporary fix. Can you fix estimateDiversity.R in this PR (change the title also according to that)

Signed-off-by: Daena Rys <[email protected]>
@Daenarys8 Daenarys8 changed the title Fix macos workflow Temporal fix for rworkflow bug May 10, 2024
@TuomasBorman
Copy link
Contributor

Roxygen2 changed how list is created. It seems that it throws now a warning. This is related to this issue: #532

Check the workflow run, you will see these warnings:


 Warning in readLines(conn, line - oldline, warn = FALSE) :
    invalid input found on input connection './man/estimateDominance.Rd'
  checkRd: (-1) estimateDominance.Rd:99-101: Lost braces in \itemize; meant \describe ?

Can you fix them?

See for example from here how lists are now created

@Daenarys8 Daenarys8 self-assigned this May 11, 2024
Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Collaborator Author

@TuomasBorman I think we can finalize this now. Unless, you have more changes in mind

@TuomasBorman
Copy link
Contributor

Looks good, but still not working. Update manual pages, let's see if that works

@Daenarys8
Copy link
Collaborator Author

Daenarys8 commented May 13, 2024

I updated man pages already. The fail is as at the stage of deployment. Something about the bot not having permission to deploy to the repo. See log here

Signed-off-by: Daena Rys <[email protected]>
@TuomasBorman
Copy link
Contributor

Now there is another error. Can you remove the rworkflows file and then create a new one with rworkflows::use_workflow(). That should update the workflow. Remember to specify R version to 4.4.0 (auto seems not to work)

In the future, create branch directly to mia. It is simpler since then I can also contribute much easier.

Signed-off-by: Daena Rys <[email protected]>
@TuomasBorman TuomasBorman mentioned this pull request May 13, 2024
@TuomasBorman
Copy link
Contributor

neurogenomics/rworkflows#130

Try to put R back to auto. It should work

Signed-off-by: Daena Rys <[email protected]>
@TuomasBorman
Copy link
Contributor

From the rworkflows issue

One thing that might help is removing the ubuntu-latest rspm line, or replacing it with rspm: ~

Can you try that fix?

Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Collaborator Author

From the rworkflows issue

One thing that might help is removing the ubuntu-latest rspm line, or replacing it with rspm: ~

Can you try that fix?

Yeah, I tried this. Still failing. I think the issue here is permission to microbiome/mia.git is denied to github-actions[bot]. I'm not quite sure but did we alter the secrets?

Signed-off-by: Daena Rys <[email protected]>
@Daenarys8 Daenarys8 changed the base branch from devel to fix-workflow May 14, 2024 06:16
@Daenarys8 Daenarys8 merged commit e739d6e into microbiome:fix-workflow May 14, 2024
2 of 3 checks passed
Daenarys8 added a commit that referenced this pull request May 14, 2024
@TuomasBorman
Copy link
Contributor

From the rworkflows issue

One thing that might help is removing the ubuntu-latest rspm line, or replacing it with rspm: ~

Can you try that fix?

Yeah, I tried this. Still failing. I think the issue here is permission to microbiome/mia.git is denied to github-actions[bot]. I'm not quite sure but did we alter the secrets?

Yes, I noticed that too. However, nothing should have changed. I will check

@TuomasBorman TuomasBorman mentioned this pull request May 14, 2024
Daenarys8 added a commit to Daenarys8/mia that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants