countDominantTaxa output table

[himmil]

No description provided.

[TuomasBorman]

round could be an integer --> that would simplify the code

How about using digits as parameter name? round() has a parameter called that.

Also add input check for round parameter

[antagomir]

We should use the same argument name than the round function itself, this will be more clear.

[antagomir]

up

[antagomir]

@himmil this PR has been open for a month; could we aim to close soon?

[antagomir]

This PR has been merged but it says above that "This branch is out-of-date with the base branch", and this PR also hasnt been closed. Can we do that as well, or is something else still missing?

[himmil]

Apparently the testing file needs to be edited as well once the output table has changed.

[antagomir]

Yes, update all relevant files and complete the PR. Ask for support through Slack where necessary.

[antagomir]

Resolve the conversation issues when they become solved. This way we can remove points that have been successfully addressed.

[antagomir]

This branch is out-of-date with the base branch

[antagomir]

Thanks - one more request.

Could you also deprecate the name countDominantTaxa and take into use new name countDominantFeatures?

You can check other deprecated functions for an example.

The unit tests and vignette should be updated accordingly, after merging also the OMA examples.

[antagomir]

check how to complete..

[TuomasBorman]

Looks good, check comments; just minor things

[antagomir]

still on the way?

[himmil]

I also added the changes regarding to issues #393 and #377 into this PR, apologies for the inconvenience..

[antagomir]

For clarity, perhaps you can announce when this PR is ready for review.

[himmil]

It's ready for review.

[antagomir]

ok - @TuomasBorman

[antagomir]

Hmm seems merging is blocked until @TuomasBorman approves too.

(we could see if it is possible to remove the requirement of multiple approvals)

[himmil]

I don't have write access so could you either merge it for me or give me the permission?