-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loadFromBiom: prefix match #362
Conversation
Previously, "k__" matched also with "sk__" prefix that can be found from biom files. This is now fixed I will update version and news, if this is ok |
Does "sk__" have a meaning, or is it a typo? |
I guess it is in Biom files to denote upper class compared to Kingdom. One dataset had mitochondria which broke the import because we have not taken this "sk" class into account |
Ok from my side. Just thinking if we should handle those special cases somehow. |
This affects only renaming of rowData columns.
We had discussion with Felix about TAXONOMY_RANKS in mia. --> we decided to include only "real" taxonomy ranks (ASV and OTU was not added). I think this is little bit similar situation. |
Yes, good. |
Status of this? Seems related to the discussion in the Tengeler data set PR data import part. |
This is good, I will update the branch This is not directly related to Tengeler data PR --> there is something else happening |
To be closed when possible, ideal to not have too many open PRs simultaneously. |
Status of this? |
This is good to go |
Ok. It is most clear if the initiator of the PR can close it. This way we can avoid premature closings. Confirm by closing the issue. |
No description provided.