Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loadFromBiom: prefix match #362

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Fix loadFromBiom: prefix match #362

merged 9 commits into from
Jul 20, 2023

Conversation

TuomasBorman
Copy link
Contributor

No description provided.

@TuomasBorman
Copy link
Contributor Author

Previously, "k__" matched also with "sk__" prefix that can be found from biom files. This is now fixed

I will update version and news, if this is ok

@antagomir
Copy link
Member

Does "sk__" have a meaning, or is it a typo?

@TuomasBorman
Copy link
Contributor Author

I guess it is in Biom files to denote upper class compared to Kingdom. One dataset had mitochondria which broke the import because we have not taken this "sk" class into account

@antagomir
Copy link
Member

Ok from my side. Just thinking if we should handle those special cases somehow.

@TuomasBorman
Copy link
Contributor Author

This affects only renaming of rowData columns.

  1. User can specify whether he/she wants to rename columns
  2. Columns are renamed based on match, e.g., "k__" --> "Kingdom"
  3. If column is not matched, the column name is unchanged

We had discussion with Felix about TAXONOMY_RANKS in mia. --> we decided to include only "real" taxonomy ranks (ASV and OTU was not added). I think this is little bit similar situation.

@antagomir
Copy link
Member

Yes, good.

@antagomir
Copy link
Member

Status of this? Seems related to the discussion in the Tengeler data set PR data import part.

@TuomasBorman
Copy link
Contributor Author

This is good, I will update the branch

This is not directly related to Tengeler data PR --> there is something else happening

@antagomir
Copy link
Member

To be closed when possible, ideal to not have too many open PRs simultaneously.

@antagomir
Copy link
Member

Status of this?

@TuomasBorman
Copy link
Contributor Author

This is good to go

@antagomir
Copy link
Member

Ok. It is most clear if the initiator of the PR can close it. This way we can avoid premature closings.

Confirm by closing the issue.

@TuomasBorman TuomasBorman merged commit ffb0444 into master Jul 20, 2023
1 check passed
@TuomasBorman TuomasBorman deleted the biom_fix branch July 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants