full coverage on port-scanner

packages/port-scanner/esm/port-scanner.mjs

@@ -0,0 +1,6 @@
+import mod from "../lib/port-scanner.js";
+
+export default mod;
+export const commonPorts = mod.commonPorts;
+export const convertHighResolutionTime = mod.convertHighResolutionTime;
+export const connect = mod.connect;

packages/port-scanner/lib/port-scanner.js

@@ -11,7 +11,6 @@ const
  LightMap = require( '@mi-sec/lightmap' ),
  NetworkCidr = require( '@mi-sec/network-cidr' );
 
-console.log( NetworkCidr );
 const commonPorts = new LightMap( [
  [ 7, 'echo' ],
  [ 9, 'discard' ],

packages/port-scanner/package.json

@@ -14,7 +14,7 @@
  "build": "gen-esm-wrapper ./lib/* ./esm/port-scanner.mjs",
  "lint": "eslint .",
  "test": "nyc --reporter=lcov --reporter=text-summary mocha",
- "testd": "nyc mocha"
+ "testd": "NODE_ENV=TESTING nyc mocha"
  },
  "keywords": [
  "netx",
@@ -33,7 +33,7 @@
  },
  "dependencies": {
  "@mi-sec/lightmap": "0.1.6",
- "@mi-sec/network-cidr": "latest"
+ "@mi-sec/network-cidr": "1.0.2"
  },
  "devDependencies": {
  "chai": "4.2.0",

packages/port-scanner/test/port-scanner.test.js

@@ -6,19 +6,24 @@
 'use strict';
 
 const
- net = require( 'net' ),
- chai = require( 'chai' ),
- { expect } = chai;
+ chai = require( 'chai' ),
+ net = require( 'net' ),
+ { ADDRCONFIG, V4MAPPED } = require( 'dns' ),
+ { expect } = chai;
 
 const
- PortScanner = require( '../lib/port-scanner' ),
- { convertHighResolutionTime } = PortScanner;
+ PortScanner = require( '../lib/port-scanner' ),
+ {
+ connect,
+ convertHighResolutionTime
+ } = PortScanner;
 
-describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version } localhost`, function () {
- const
- host = '127.0.0.1/32',
- banner = 'hello\r\n';
+const
+ host = '127.0.0.1/32',
+ banner = 'hello\r\n';
 
+// TODO: these tests are a bit flaky and rely on assumed compute drift timeouts. circle back sometime
+describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version } localhost`, function () {
  let server, ports;
 
  beforeEach( ( done ) => {
@@ -49,7 +54,7 @@ describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version
  } );
  } );
 
- it( `should scan target ${ host } and determine it "open" with banner "hello\\r\\n"`, async () => {
+ it( `should scan target ${ host } and determine "open" with banner "hello\\r\\n"`, async () => {
  const start = process.hrtime();
  const result = new PortScanner( { host, ports, attemptToIdentify: true } );
 
@@ -64,7 +69,7 @@ describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version
 
  const end = convertHighResolutionTime( process.hrtime( start ) );
 
- expect( end ).to.be.lte( 5.0 );
+ expect( end ).to.be.lte( 10.0 );
 
  expect( data ).to.be.an( 'object' );
  expect( data ).to.have.property( 'host' ).and.be.a( 'string' ).and.eq( host.split( '/' )[ 0 ] );
@@ -81,7 +86,34 @@ describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version
  expect( done.get( key ) ).to.deep.eq( data );
  } );
 
- it( `should scan target ${ host } and determine it "close"`, async () => {
+ it( `should scan target ${ host } and determine "timeout"`, async () => {
+ const port = ports[ 0 ];
+ let d1, d2;
+
+ d1 = await connect( host, port, { timeout: 1, onlyReportOpen: true } );
+
+ try {
+ await connect( host, port, {
+ timeout: 0,
+ connectionOpts: {
+ hints: ADDRCONFIG | V4MAPPED
+ }
+ } );
+ }
+ catch ( e ) {
+ d2 = e;
+ }
+
+ expect( d1 ).to.eq( undefined );
+
+ expect( d2 ).to.be.an( 'object' );
+ expect( d2 ).to.have.property( 'host' ).and.eq( host );
+ expect( d2 ).to.have.property( 'port' ).and.eq( port );
+ expect( d2 ).to.have.property( 'status' ).and.eq( 'closed' );
+ expect( d2 ).to.have.property( 'error' ).and.be.an.instanceOf( Error );
+ } );
+
+ it( `should scan target ${ host } and determine "close"`, async () => {
  server.close();
 
  const start = process.hrtime();
@@ -97,7 +129,7 @@ describe( `${ process.env.npm_package_name } v${ process.env.npm_package_version
  await result.scan();
  const end = convertHighResolutionTime( process.hrtime( start ) );
 
- expect( end ).to.be.lte( 5.0 );
+ expect( end ).to.be.lte( 10.0 );
 
  expect( data ).to.be.an( 'object' );
  expect( data ).to.have.property( 'host' ).and.be.a( 'string' ).and.eq( host.split( '/' )[ 0 ] );
@@ -168,7 +200,6 @@ describe( [
  .on( 'progress', ( d ) => progress = d )
  .on( 'done', ( d ) => {
  expect( progress ).to.be.a( 'number' ).and.eq( 1 );
- y;
 
  expect( d.size ).to.eq( 4 );
  expect( d.has( '127.0.0.1:80' ) ).to.eq( true );