Improve consistency/reliability of name comparisons #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mhutch
commented
May 3, 2024
•
mhutch
commented
- Update MD.Xml for updated XName comparison APIs
- Use new XName comparison APIs
- Define and consistently use constants for element name, attribute names, diagnostic property names, and taskfactory names
- Improve various name comparison checks to be more accurate
mhutch
force-pushed
the
comparisons-and-constants
branch
4 times, most recently
from
12cc077
to
43fa374
Compare
mhutch
changed the title
Also, fix KeepDuplicates attribute on Item element
mhutch
force-pushed
the
comparisons-and-constants
branch
from
43fa374
to
2bece0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.