Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various nullability fixes across MD.Xml and MD.MSBuild #222

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Various nullability fixes across MD.Xml and MD.MSBuild #222

merged 3 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. Fix start position of directory completion

    @mhutch
    mhutch committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    17cbf5e View commit details
    Browse the repository at this point in the history

  2. Assorted nullability fixes

    @mhutch
    mhutch committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    90fc548 View commit details
    Browse the repository at this point in the history

  3. Fix locating best ItemInfo from schemas 

    When other schemas add metadata to an existing item, they
essentially redefine it, but with only that metadata, and no type
or description. Metadata lookups merge the metadata from all
these defintions.

However, when locating the ItemInfo for the type/description, we
preferentially search for an ItemInfo that doesn't just have metadata.
This search was broken and is now fixed.
    @mhutch
    mhutch committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d11773d View commit details
    Browse the repository at this point in the history