Add more known legacy TFMs #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For frameworks where the shortname does not exactly match the built-in map, but for which NuGet is able to resolve as an alias, handle validation of the platform and profile correctly.
This doesn't cover all the esoteric legacy TFMs, and may not handle them all correctly, but it should be an improvement
We don't have the data for all known revisions so it will fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
Note that handling and validating all possible TFMs is extremely difficult, as it's ultimately up to the targets how they are interpreted. In the long term I would like to switch to allowing the targets' build schemas to define the known TFMs, and add better support for aliased TFMs and deprecated TFMs.