Add .NET Aspire schemas #215
Conversation
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "license": "Copyright (c) Microsoft. All rights reserved. Licensed under the MIT license. See LICENSE file in the project root for full license information.", | |||
| "properties": { | |||
There was a problem hiding this comment.
Would it also be possible to document here metadata on specific Items? I'm mainly asking as it would be interesting if we can also provide info around IsAspireProjectResource. cc: @eerhardt
See https://github.com/dotnet/aspire/blob/c6d17908dce366b8c08b77509f2ce692b861cbd1/src/Aspire.Hosting.Sdk/SDK/Sdk.targets#L22 for more info
There was a problem hiding this comment.
Nevermind, I see you did this already in AspireHostingSDK
| "DcpDir": { | ||
| "description": "The path to the directory containing the DCP tools.", | ||
| "type": "folder-with-slash" | ||
| }, | ||
| "DcpExtensionsDir": { | ||
| "description": "The path to the directory containing the DCP tool extensions.", | ||
| "type": "folder-with-slash" | ||
| }, | ||
| "DcpBinDir": { | ||
| "description": "The path to the directory containing the DCP tool extension binaries.", | ||
| "type": "folder-with-slash" | ||
| }, | ||
| "DcpCliPath": { | ||
| "description": "The path to the DCP CLI executable.", | ||
| "type": "file" | ||
| } |
There was a problem hiding this comment.
I don't think we want users setting these properties at all. These are more "internal" properties to Aspire.
There was a problem hiding this comment.
They'll be in completion anyways as they'll be discovered in the imported targets - so I figured they may as well have docs. The MSBuild Editor only hides symbols that use the underscore prefix convention to indicate private/internal use.
There was a problem hiding this comment.
ok, that makes sense. Thanks for the explanation.
There was a problem hiding this comment.
Would it make sense to add something like (for testing/validation scenarios) to indicate that they aren't properties we'd normally expect to be customized?
Added schemas for .NET Aspire
Fixes #203