More specific diagnostic message for invalid NuGet version

mhutch · Apr 17, 2024 · bacc18d · bacc18d
1 parent 136a024
commit bacc18d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/MonoDevelop.MSBuild/Language/CoreDiagnostics.cs b/MonoDevelop.MSBuild/Language/CoreDiagnostics.cs
@@ -470,6 +470,13 @@ class CoreDiagnostics
 			"The value `{0}` is not a valid suffixed version format",
 			MSBuildDiagnosticSeverity.Error);
 
+		public const string InvalidNuGetVersionExpression_Id = nameof (InvalidNuGetVersionExpression);
+		public static readonly MSBuildDiagnosticDescriptor InvalidNuGetVersionExpression = new (
+			InvalidNuGetVersionExpression_Id,
+			"Invalid NuGet version expression",
+			"The value `{0}` is not a valid NuGet version or version expression.",
+			MSBuildDiagnosticSeverity.Error);
+
 		public const string InvalidClrNamespace_Id = nameof (InvalidClrNamespace);
 		public static readonly MSBuildDiagnosticDescriptor InvalidClrNamespace = new (
 			InvalidClrNamespace_Id,

diff --git a/MonoDevelop.MSBuild/Language/MSBuildDocumentValidator.cs b/MonoDevelop.MSBuild/Language/MSBuildDocumentValidator.cs
@@ -684,7 +684,7 @@ void VisitPureLiteral (MSBuildElementSyntax elementSymbol, MSBuildAttributeSynta
 				break;
 			case MSBuildValueKind.NuGetVersion:
 				if (!NuGet.Versioning.VersionRange.TryParse (value, out _)) {
-					AddErrorWithArgs (CoreDiagnostics.InvalidVersionSuffixed, value);
+					AddErrorWithArgs (CoreDiagnostics.InvalidNuGetVersionExpression, value);
 				}
 				break;
 			case MSBuildValueKind.VersionSuffixed: