Adding support for running metrics against a particular git hash #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he filename containing a date.
| s.cert_chain = ['certs/bf4.pem'] | ||
| s.signing_key = File.expand_path("~/.ssh/gem-private_key.pem") if $0 =~ /gem\z/ | ||
| #s.cert_chain = ['certs/bf4.pem'] | ||
| #s.signing_key = File.expand_path("~/.ssh/gem-private_key.pem") if $0 =~ /gem\z/ |
There was a problem hiding this comment.
I'm guessing you didn't mean to include this in the PR, but I understand why you made it :)
…houldnt have been checked in commented out in the first place
|
I addressed many of the issues you brought up (thanks for the suggestions BTW). Let me know if there's anything else that I can take a look at. I may still try to abstract out the version control system if possible. |
|
Please rebase against master, amend to remove extraneous commits, and get the tests passing! |
| @@ -55,20 +57,64 @@ def configure_metric(metric, metric_options) | |||
| end | |||
| end | |||
| def configure_formatters(options) | |||
| filename = options[:githash] # Set the filename for the output; nil is a valid value | |||
There was a problem hiding this comment.
That's a little misleading, no? Why not just do
metric_filename = options.fetch(:githash) { filename_timestamp(Time.now) }
def filename_timestamp(time)
time.strftime("%Y%m%d")
end
|
Let me know if you want to pair on this. I have a lot more comments. |
|
I've been thinking.. this functionality should probably use the git tooling included in Churn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding git support to metric_fu to allow users to specify a git hash to run metric_fu against.
Saves the resulting yml file using the git hash as the filename. This can allow users to diff results across change lists.