Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapsible to GlobalFieldDefinitionType type in XSD #37

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ronaldtse
Copy link

Committer Notes

Fixes #36.

This is ported from usnistgov/metaschema#775.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@ronaldtse
Copy link
Author

Ping @david-waltermire @wendellpiez , sorry for the duplicated PR, wasn't sure where to send this to until I've made the first...

@ronaldtse
Copy link
Author

Thanks @aj-stein-gsa ! Can I confirm that the metaschema framework is now managed here instead of at the usnistgov account?

@aj-stein-gsa
Copy link
Contributor

Thanks @aj-stein-gsa ! Can I confirm that the metaschema framework is now managed here instead of at the usnistgov account?

This is an active fork of that project fixing bugs and adding features. Not sure what we define as official but the maintainers here will follow up after reviewing this PR, a few others, and wrapping up a release of the Java library.

Expect a more formal answer when we come back to this PR. I just wanted to look quickly as I was in this part of the code base and noticed your nice contribution!

@david-waltermire
Copy link
Contributor

david-waltermire commented Oct 26, 2024

Support for the unused and confusing collapse Metaschema feature was removed in usnistgov/metaschema#405. It looks like the unit tests need to be cleaned up instead of adding this back in to the schema and metaschema-module. Would you revert this change and cleanup the unit test instead?

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to take a different direction as noted in the discussion above.

@aj-stein-gsa
Copy link
Contributor

Support for the unused and confusing collapse Metaschema feature was removed in usnistgov/metaschema#405. It looks like the unit tests need to be cleaned up instead of adding this back in to the schema and metaschema-module. Would you revert this change and cleanup the unit test instead?

Sorry, @david-waltermire. I completely forgot about this.

@aj-stein-gsa aj-stein-gsa self-requested a review October 27, 2024 22:31
@wendellpiez
Copy link
Contributor

Glad to confirm that removing this unused feature would be most welcome (thanks @david-waltermire).

@ronaldtse, glad to talk about your larger question maybe in our next meeting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalFieldDefinitionType missing definition for collapsible causing failure in test-suite sample
4 participants