-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapsible
to GlobalFieldDefinitionType
type in XSD
#37
base: develop
Are you sure you want to change the base?
Add collapsible
to GlobalFieldDefinitionType
type in XSD
#37
Conversation
Ping @david-waltermire @wendellpiez , sorry for the duplicated PR, wasn't sure where to send this to until I've made the first... |
Thanks @aj-stein-gsa ! Can I confirm that the metaschema framework is now managed here instead of at the usnistgov account? |
This is an active fork of that project fixing bugs and adding features. Not sure what we define as official but the maintainers here will follow up after reviewing this PR, a few others, and wrapping up a release of the Java library. Expect a more formal answer when we come back to this PR. I just wanted to look quickly as I was in this part of the code base and noticed your nice contribution! |
Support for the unused and confusing collapse Metaschema feature was removed in usnistgov/metaschema#405. It looks like the unit tests need to be cleaned up instead of adding this back in to the schema and metaschema-module. Would you revert this change and cleanup the unit test instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to take a different direction as noted in the discussion above.
Sorry, @david-waltermire. I completely forgot about this. |
Glad to confirm that removing this unused feature would be most welcome (thanks @david-waltermire). @ronaldtse, glad to talk about your larger question maybe in our next meeting? |
Committer Notes
Fixes #36.
This is ported from usnistgov/metaschema#775.
All Submissions:
Changes to Core Features: