Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vc/validation integration #31

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

DoctorVin
Copy link
Contributor

@DoctorVin DoctorVin commented Oct 4, 2024

What does this PR do

I refactored the firmware validation function in flipflop to use a "low-level" Supermicro handle. The structure of code is reworked a bit as well, and I defined some internal interfaces to make mocking and testing a little easier. I also added a test for our firmware validation routine.

DoctorVin and others added 8 commits September 10, 2024 11:40
I imported a pre-release version of bmclib to get access to the new
versions of the supermicro client object. Using that I defined some
minimalist interfaces and used mockery to provide test collateral.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Doctor Vince <[email protected]>
@DoctorVin DoctorVin marked this pull request as ready for review October 4, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants