Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEARCH-452, SEARCH-677: Index all URL relationships and fix indexing disambiguation comments #135

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

SEARCH-452, SEARCH-677: Index all URL relationships and fix indexing disambiguation comments #135

wants to merge 10 commits into from

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Jun 3, 2022

Problems

  1. Only artist and release relationships were indexed so far
  2. Contrarily to other related entities, place and recording were missing disambiguation comment.

Solution

  1. SEARCH-452: Index all URL relationships
  2. SEARCH-677: Include disambiguation of event's place and work's recording

These two tickets are resolved together because they use the same functions in code behind the scenes.

Checklist for author

  • Test locally
  • Update CI tests if needed
  • Check the increase of size for indexes

Action

On deployment:

  1. Rebuild the three search indexes: event, url, work

yvanzo added 10 commits June 3, 2022 16:40
@yvanzo
Update function DocStrings for convert_*relation*
76ccd6e
@yvanzo
SEARCH-677 (I): Index comment of event’s place
3977b7a 
It stays compatible with MMD schema 2.0 v-2020-11-12.

Rebuilding the event index is needed to make it available.
@yvanzo
SEARCH-677 (II): Index comment of work’s recording
b091165 
It stays compatible with MMD schema 2.0 v-2020-11-12.

Rebuilding the event index is needed to make it available.
@yvanzo
Refactor to convert area-URL relationship
9c17330
@yvanzo
Document that place rel conversion works with URL
53cf4db
@yvanzo
Refactor to convert recording-URL relationship
90fc362
@yvanzo
Refactor release group simple conversion
8406bd8
@yvanzo
Convert release group-URL relationship
aa8027f
@yvanzo
Convert remaining URL relationship
ce68b81 
Convert:
- event-URL relationship
- instrument-URL relationship
- label-URL relationship
- series-URL relationship
- work-URL relationship

All other URL relationships already have a conversion function.
@yvanzo
SEARCH-452: Index all URL relationships
1b49d2e 
Additionally to URL relationships to artists and releases, this patch
indexes URL relationships to events, instruments, labels, places,
recordings, release groups, series, and work, with the same data:
gid, name, disambiguation comment if available, and video for recording.

Rebuilding the url index is needed to make these available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yvanzo