Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #370 - Seq command compatability issue #990

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

woo200
Copy link

@woo200 woo200 commented Jan 3, 2024

Fixed issue #370, Because seq command on some windows environments doesn't have the -f flag, it fails to download any of the models. Replaced with very basic seq command and printf for fomatting.
Also fixed issue where model size default was not getting set.
Tested on windows and ubuntu, does not appear to change functionality in any negative way.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2024
Copy link

@Dmellies Dmellies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶

Copy link

@Dmellies Dmellies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants