Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/browser setup #205

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

PixnBits
Copy link
Contributor

I noticed there were no automated tests. I'd wager it is probably effective to start with browser testing than unit tests in the event of some implementation refactoring. This is a setup with Playwright, with the start of some tests. I can continue to expand the tests if this approach is desirable, or change course based on maintainer feedback 👍

@PixnBits
Copy link
Contributor Author

PixnBits commented May 18, 2024

I did have the image snapshots added

$ git status
...
new file:   tests/example.spec.ts-snapshots/Prompts-adding-a-new-connection-as-the-call-to-action-when-there-are-no-devices-1-chromium-linux.png
new file:   tests/example.spec.ts-snapshots/Shows-the-protocols-as-the-first-step-of-adding-a-device-1-chromium-linux.png
new file:   tests/example.spec.ts-snapshots/connect-over-http-chromium-linux.png
new file:   tests/example.spec.ts-snapshots/connect-over-serial-chromium-linux.png

but when pushing to my fork I got the message

$ git push --set-upstream origin test/browser-setup 
batch response: @PixnBits can not upload new objects to public fork PixnBits/meshtastic-web                                                                                                                                         
error: failed to push some refs to 'github.com:PixnBits/meshtastic-web.git'

When looking for the cause or a needed setting I found

Git LFS on github.com does not currently support pushing LFS objects to public forks.

git-lfs/git-lfs#1906 (comment)

The image snapshots could be useful for documentation purposes in addition to quick visual change checks, but with this restriction by GitHub could be an impediment to contributors?

package.json Outdated Show resolved Hide resolved
@Hunter275 Hunter275 added enhancement New feature or request major change This is a major change labels Jun 16, 2024
the test file is an example, does not test this project in any way, and will be removed as tests for this project are written and the example is no longer needed
@PixnBits
Copy link
Contributor Author

PixnBits commented Jul 9, 2024

Before moving this PR to a ready state we might need to think through the impact of GitHub's image storage on contributions?
#205 (comment)

I'm in the Meshtastic Discord "server" if that helps \m/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this example file before moving the PR to ready for review 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major change This is a major change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants