Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive selection line to device metrics chart #817

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add interactive selection line to device metrics chart #817

merged 1 commit into from
Jul 30, 2024

Conversation

garthvh
Copy link
Member

@garthvh garthvh commented Jul 23, 2024 •
edited
Loading

Allows for chart selection from both the table below the chart and the chart itself.

There is an annotation that I commented out, not sure what it would display here.

@RCGV1 I got the start of some interactivity going.

@garthvh garthvh requested a review from 72A12F4E July 23, 2024 22:10
@garthvh garthvh marked this pull request as draft July 23, 2024 22:10
@garthvh garthvh requested review from thebentern and RCGV1 July 23, 2024 22:11
@garthvh garthvh marked this pull request as ready for review July 30, 2024 03:40
@garthvh garthvh merged commit e4299ae into main Jul 30, 2024
5 checks passed
@garthvh garthvh deleted the device-metric-interactive-chart branch July 30, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCGV1 RCGV1 RCGV1 approved these changes

@72A12F4E 72A12F4E Awaiting requested review from 72A12F4E

@thebentern thebentern Awaiting requested review from thebentern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garthvh @RCGV1