Merge pull request #48 from mercadolibre/fix/discount-tracker

Discount tracker protocol updated
mercadolibre · Feb 7, 2020 · 34e8b7b · 34e8b7b
2 parents 78bfe59 + 5fc568b
commit 34e8b7b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # v1.8.1
 🚀 1.8.1 🚀
 - Restored tap tracking on Discount Box component.
+- Modified MLBusinessDiscountTrackerProtocol.
 
 # v1.8
 🚀 1.8 🚀

diff --git a/Example/Example_BusinessComponents/MockData/DiscountTrackerData.swift b/Example/Example_BusinessComponents/MockData/DiscountTrackerData.swift
@@ -18,7 +18,7 @@ class DiscountTrackerData: NSObject, MLBusinessDiscountTrackerProtocol {
         self.touchPointId = touchPointId
     }
 
-    func track(action: String, eventData: [[String : Any]]) {
+    func track(action: String, eventData: [String : Any]) {
         //Melidata tracking
         print("Melidata track path: \(basePath)/\(touchPointId)/\(action) with event data: \(eventData)")
     }

diff --git a/Source/Commons/MLBusinessDiscountTrackerProtocol.swift b/Source/Commons/MLBusinessDiscountTrackerProtocol.swift
@@ -8,5 +8,5 @@
 import Foundation
 
 @objc public protocol MLBusinessDiscountTrackerProtocol: NSObjectProtocol {
-    func track(action: String, eventData: [[String : Any]])
+    func track(action: String, eventData: [String : Any])
 }
diff --git a/Source/Components/Discount/MLBusinessDiscountBoxView.swift b/Source/Components/Discount/MLBusinessDiscountBoxView.swift
@@ -115,14 +115,14 @@ private extension MLBusinessDiscountBoxView {
         }
     }
 
-    private func getEventDataFrom(discountItems: [MLBusinessSingleItemProtocol]) -> [[String : Any]] {
+    private func getEventDataFrom(discountItems: [MLBusinessSingleItemProtocol]) -> [String : Any] {
         var eventData = [[String : Any]]()
         for discountItem in discountItems {
             if let eventDataForItem = discountItem.eventDataForItem?() {
                 eventData.append(eventDataForItem)
             }
         }
-        return eventData
+        return ["items" : eventData]
     }
 
     private func updateUI() {
@@ -156,7 +156,7 @@ private extension MLBusinessDiscountBoxView {
 extension MLBusinessDiscountBoxView: MLBusinessUserInteractionProtocol {
     func didTap(item: MLBusinessSingleItemProtocol, index: Int, section: Int) {
         if let viewData = viewData, let trackingProvider = viewData.getDiscountTracker?(), let eventDataForItem = item.eventDataForItem?() {
-            trackingProvider.track(action: "tap", eventData: [eventDataForItem])
+            trackingProvider.track(action: "tap", eventData: eventDataForItem)
         }
 
         tapAction?(index, item.deepLinkForItem(), item.trackIdForItem())