Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

add read timeout #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vinipsmaker
Copy link

This commit adds a set_read_timeout function similar to Rust's
set_read_timeout[1]. The differences compared to upstream are:

  • Operation always succeed.
  • It takes an i64 instead Duration.

[1] https://doc.rust-lang.org/nightly/std/net/struct.UdpSocket.html#method.set_read_timeout

@vinipsmaker
Copy link
Author

PR updated/rebased

This commit adds a `set_read_timeout` function similar to Rust's
`set_read_timeout`[1]. The differences compared to upstream are:

- Operation always succeed.
- It takes an u64 instead Duration.

[1] https://doc.rust-lang.org/nightly/std/net/struct.UdpSocket.html#method.set_read_timeout
@vinipsmaker
Copy link
Author

PR updated.

It's a lot more stable now.

@vinipsmaker
Copy link
Author

On our usage of rust-utp, a stress test to study rust-utp was used and the failure rate was around 50%. With the new set-read-timeout, failure rate went to 0% (we already executed the test plenty of time and still no sign of failure). It's definitively more stable now.

vinipsmaker added a commit to vinipsmaker/rust-utp that referenced this pull request Dec 29, 2015
@vinipsmaker
Copy link
Author

We're still executing tests to find more problems within rust-utp and we found a few:

All of them touches different parts of the code and show problems that are unrelated to this PR. I'd appreciate any input on this, as it's becoming a burden to maintain separate sets of patchsets. Merging just this one PR would already make things a tad easier, as it'd allow me to maintain the same set of changes to our code and to the upstream rust-utp, as this PR introduces a fundamental change in code.

@meqif meqif force-pushed the master branch 4 times, most recently from 9b080c4 to f507b7b Compare August 17, 2016 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant