Update SearchOptions to work like a more usual builder #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase to remove the extra commits? |
xremming
force-pushed
the
search-options-no-mut
branch
from
cfe2537
to
a4a5a25
Compare
|
Should be correctly rebased now. |
mendess
approved these changes
May 27, 2024
xremming
force-pushed
the
search-options-no-mut
branch
from
a4a5a25
to
afd9f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the changes from the #44 PR because oops.
I changed the
SearchOptionsstruct to work more like a usualbuilder object with the methods taking ownership of the struct
and returning it back modified. I also added
CloneandPartialEqso a partially built
SearchOptionsobject can be reused easily.