Add more guidance on Ruby #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcljx
approved these changes
Aug 29, 2023
Comment on lines
+25
to
+26
| - Python 3.8 or later | ||
| - Ruby 2.7.7 |
There was a problem hiding this comment.
Lazy me would just have done:
You'll need:
- Python (see
.python-versionfor version)- Ruby (see
.ruby-versionfor version)
There was a problem hiding this comment.
Fair point, but then I wouldn't get to force a workflow to fail, which is fun 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can pretty easily run into errors building if the right version of Ruby isn't being used.
This commit adds more guidance on managing Ruby versions, as well as setting up a Python
virtual environment.
To ensure the version of Ruby newly listed in
readme.mdmatches the.ruby-versionfile,a GitHub workflow has been added.
The workflow can be tested by running it manually:
The workflow was tested by checking for failure when either the
readme.mdor the.ruby-versionwas changed and there was a mismatch. Checked forsuccess by reverting each change. Results are
here.
Sadly didn't know re-named workflows generate a new workflow and can't
get removed...so
there is an extra workflow in Actions from when I
renamed the workflow that I've disabled for now.