Implement some epsilon related checks for heat so that fusion reactor…

…s don't occasionally just get marked as dirty all the time when inactive
mekanism · Aug 1, 2023 · 0071ff4 · 0071ff4
1 parent 6fc8754
commit 0071ff4
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 12 deletions.
diff --git a/src/api/java/mekanism/api/heat/HeatAPI.java b/src/api/java/mekanism/api/heat/HeatAPI.java
@@ -1,5 +1,6 @@
 package mekanism.api.heat;
 
+import com.mojang.math.Constants;
 import net.minecraft.core.BlockPos;
 import net.minecraft.util.Mth;
 import net.minecraft.world.level.LevelReader;
@@ -33,6 +34,12 @@ private HeatAPI() {
  * Default inverse insulation coefficient
  */
  public static final double DEFAULT_INVERSE_INSULATION = 0;
+ /**
+ * Represents the value at which changes to heat below this amount will not be taken into account by Mekanism.
+ *
+ * @since 10.4.0
+ */
+ public static final double EPSILON = Constants.EPSILON;
 
  /**
  * Gets the atmospheric temperature at a given spot in the specified world based on the biome's temperature modifier at that position. The baseline temperature

diff --git a/...enerators/java/mekanism/generators/common/content/fusion/FusionReactorMultiblockData.java b/...enerators/java/mekanism/generators/common/content/fusion/FusionReactorMultiblockData.java
@@ -298,18 +298,22 @@ private long burnFuel() {
  private void transferHeat() {
  //Transfer from plasma to casing
  double plasmaCaseHeat = plasmaCaseConductivity * (lastPlasmaTemperature - lastCaseTemperature);
- setPlasmaTemp(getPlasmaTemp() - plasmaCaseHeat / plasmaHeatCapacity);
- heatCapacitor.handleHeat(plasmaCaseHeat);
+ if (Math.abs(plasmaCaseHeat) > HeatAPI.EPSILON) {
+ setPlasmaTemp(getPlasmaTemp() - plasmaCaseHeat / plasmaHeatCapacity);
+ heatCapacitor.handleHeat(plasmaCaseHeat);
+ }
 
  //Transfer from casing to water if necessary
  double caseWaterHeat = MekanismGeneratorsConfig.generators.fusionWaterHeatingRatio.get() * (lastCaseTemperature - biomeAmbientTemp);
- int waterToVaporize = (int) (HeatUtils.getSteamEnergyEfficiency() * caseWaterHeat / HeatUtils.getWaterThermalEnthalpy());
- waterToVaporize = Math.min(waterToVaporize, Math.min(waterTank.getFluidAmount(), MathUtils.clampToInt(steamTank.getNeeded())));
- if (waterToVaporize > 0) {
- MekanismUtils.logMismatchedStackSize(waterTank.shrinkStack(waterToVaporize, Action.EXECUTE), waterToVaporize);
- steamTank.insert(MekanismGases.STEAM.getStack(waterToVaporize), Action.EXECUTE, AutomationType.INTERNAL);
- caseWaterHeat = waterToVaporize * HeatUtils.getWaterThermalEnthalpy() / HeatUtils.getSteamEnergyEfficiency();
- heatCapacitor.handleHeat(-caseWaterHeat);
+ if (Math.abs(caseWaterHeat) > HeatAPI.EPSILON) {
+ int waterToVaporize = (int) (HeatUtils.getSteamEnergyEfficiency() * caseWaterHeat / HeatUtils.getWaterThermalEnthalpy());
+ waterToVaporize = Math.min(waterToVaporize, Math.min(waterTank.getFluidAmount(), MathUtils.clampToInt(steamTank.getNeeded())));
+ if (waterToVaporize > 0) {
+ MekanismUtils.logMismatchedStackSize(waterTank.shrinkStack(waterToVaporize, Action.EXECUTE), waterToVaporize);
+ steamTank.insert(MekanismGases.STEAM.getStack(waterToVaporize), Action.EXECUTE, AutomationType.INTERNAL);
+ caseWaterHeat = waterToVaporize * HeatUtils.getWaterThermalEnthalpy() / HeatUtils.getSteamEnergyEfficiency();
+ heatCapacitor.handleHeat(-caseWaterHeat);
+ }
  }
 
  HeatTransfer heatTransfer = simulate();
@@ -318,8 +322,10 @@ private void transferHeat() {
 
  //Passive energy generation
  double caseAirHeat = MekanismGeneratorsConfig.generators.fusionCasingThermalConductivity.get() * (lastCaseTemperature - biomeAmbientTemp);
- heatCapacitor.handleHeat(-caseAirHeat);
- energyContainer.insert(FloatingLong.create(caseAirHeat * MekanismGeneratorsConfig.generators.fusionThermocoupleEfficiency.get()), Action.EXECUTE, AutomationType.INTERNAL);
+ if (Math.abs(caseAirHeat) > HeatAPI.EPSILON) {
+ heatCapacitor.handleHeat(-caseAirHeat);
+ energyContainer.insert(FloatingLong.create(caseAirHeat * MekanismGeneratorsConfig.generators.fusionThermocoupleEfficiency.get()), Action.EXECUTE, AutomationType.INTERNAL);
+ }
  }
 
  @NotNull

diff --git a/src/main/java/mekanism/common/capabilities/heat/BasicHeatCapacitor.java b/src/main/java/mekanism/common/capabilities/heat/BasicHeatCapacitor.java
@@ -95,7 +95,7 @@ public void handleHeat(double transfer) {
  }
 
  public void update() {
- if (heatToHandle != 0) {
+ if (heatToHandle != 0 && Math.abs(heatToHandle) > HeatAPI.EPSILON) {
  initStoredHeat();
  storedHeat += heatToHandle;
  //notify listeners