-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement attributesToSearchOn #463
Implement attributesToSearchOn #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo in the code-samples and we are ready to go!
Co-authored-by: Bruno Casali <[email protected]>
Tests work locally but failed in the workflow with the following error:
Locally with an instance set up with just:
Tests pass in my IDE: I notice the field |
@SKeeneCode you need to change this line to 1.3.0 @brunoocasali can we change this to |
… into feature-attributes-to-search-on
@ahmednfwela thanks for pointing that out ^.^ I've changed it to 1.3.0 but if brunoo says latest is fine I can do change it to that. |
Since v0.30 we have updated this version number, but I don't remember why. Let's change back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
bors merge
Build succeeded: |
Pull Request
Related issue
Fixes #457
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!