Match quality #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I thought it might be interesting to show the user how good the match for the song they got actually is.
Here is the distribution for the distance to the closest song from each possible gridpoint:
Here I've added an output among 'perfect', 'good', 'decent' and 'not a match' according to the square distance, splitting the distribution along the dotted lines.
The classification is somewhat skewed to the left but I think that makes sense - high values for the distance often correspond to very weird emotional states, like "our relationship ended because of cataclysmic past offences, but we do pretty much everything together!".