bugfix:strategy type error #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localvar
previously approved these changes
Jul 27, 2023
|
Hi uliian, Thanks for submitting this pull request. Just a heads up - the schema.json file is auto-generated by a GitHub action, so we don't modify it directly. I went ahead and submitted PR #388 that updates the schemajson of the strategy field. Would you mind taking a look when you have a chance? Let me know if you have any other questions! |
localvar
dismissed
their stale review
the file is auto generated, the approval may be wrong
|
this file is auto generated and should not be modified directly, the issue is fixed via #389 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type definition of the "strategy" field in the schema.json is incorrect. It should be defined as a string type, but it is currently defined as an integer.