Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default role based access for S3 instead of explicit credentials. #77

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use default role based access for S3 instead of explicit credentials. #77

merged 1 commit into from
Mar 7, 2024

Conversation

sonoransun
Copy link
Contributor

Use default role based access for S3 instead of explicit credentials.

dmou
dmou approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dmou dmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the client setup works in other parts of code w/ these params

@sonoransun sonoransun merged commit 6269f46 into master Mar 7, 2024
2 checks passed
@sonoransun sonoransun deleted the bugfix/use-role-for-s3-access branch March 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmou dmou dmou approved these changes

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney is a code owner

@computermacgyver computermacgyver Awaiting requested review from computermacgyver computermacgyver is a code owner

@skyemeedan skyemeedan Awaiting requested review from skyemeedan skyemeedan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonoransun @dmou