-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cv2 4126 video #54
Cv2 4126 video #54
Conversation
from lib.logger import logger | ||
def upload_file_to_s3(bucket: str, filename: str): | ||
""" | ||
Generic upload helper for s3. Could be moved over to helpers folder... | ||
""" | ||
s3_url = os.getenv('S3_ENDPOINT') | ||
access_key = os.getenv('AWS_ACCESS_KEY_ID') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In timpani, we did access using the roles, vs access key, so maybe this is not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @sonoransun weigh in on this - this is how I've usually done this sort of thing, but maybe its not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I would prefer leaving it this way as currently written as it interfaces nicely with minio locally - no biggie if that's a problem though!
lib/s3.py
Outdated
else: | ||
# Other errors like permissions issues | ||
logger.error(f'Error in accessing bucket {bucket}: {e}, {bucket} {filename}') | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this still raise the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough - I'll raise
36f8f4f
to
4b73b40
Compare
No description provided.