Cv2 4126 video #54
Merged
Cv2 4126 video #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGaffney
requested review from
computermacgyver and
skyemeedan
as code owners
skyemeedan
approved these changes
Jan 22, 2024
| from lib.logger import logger | ||
| def upload_file_to_s3(bucket: str, filename: str): | ||
| """ | ||
| Generic upload helper for s3. Could be moved over to helpers folder... | ||
| """ | ||
| s3_url = os.getenv('S3_ENDPOINT') | ||
| access_key = os.getenv('AWS_ACCESS_KEY_ID') |
There was a problem hiding this comment.
In timpani, we did access using the roles, vs access key, so maybe this is not needed?
There was a problem hiding this comment.
I'll let @sonoransun weigh in on this - this is how I've usually done this sort of thing, but maybe its not needed?
There was a problem hiding this comment.
FWIW I would prefer leaving it this way as currently written as it interfaces nicely with minio locally - no biggie if that's a problem though!
lib/s3.py
Outdated
| else: | ||
| # Other errors like permissions issues | ||
| logger.error(f'Error in accessing bucket {bucket}: {e}, {bucket} {filename}') | ||
| return |
There was a problem hiding this comment.
shouldn't this still raise the error?
There was a problem hiding this comment.
Fair enough - I'll raise
DGaffney
force-pushed
the
cv2-4126-video
branch
from
36f8f4f
to
4b73b40
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.