-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cv2 3408 add fasttext #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! some thoughts:
- maybe have a class with fields instead of dict so that we can enforce structure of items?
- I think it would be a good idea to carry an id along with the item we are predicting, so that if they get out of order (like coming off of queue, or dict keys, or if one fails) we will still be able to match up the correct items to their classifications
- @devin does this map well to how the batches of items will come off the queue?
lib/model/fasttext.py
Outdated
class FasttextModel(Model): | ||
def __init__(self): | ||
""" | ||
Load fasttext model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you include the link to the model docs here?
Quick responses:
|
So this is failing because we're on |
Woo! Ok, this works now with some updates I made to python package versions (well, at least, we're not failing on builds anymore...) @amydunphy the code is now failing on a test - looks like we accidentally named some variables wrongly - can you take a look and have a first pass at fixing these when you've got time?
|
This is close enough that we can test it in QA! Thank you @amydunphy for this great work. |
initial addition of fasttext language identification to presto https://meedan.atlassian.net/browse/CV2-3408