Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cv2 3525 remove chromaprint local #15

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

DGaffney
Copy link
Collaborator

No description provided.

@DGaffney DGaffney changed the base branch from master to develop July 24, 2023 15:49
Copy link
Contributor

@skyemeedan skyemeedan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add description to PR with link to our lovely new chromaprint repo before you merge? (I'm assuming it worked when you ran it ;-)

@DGaffney
Copy link
Collaborator Author

Pretty thin description here -

Right now we just copy/paste chromaprint directly into presto. We should install via our github.com/meedan/chromaprint version instead, and do so during the docker build!

I did in fact verify that this works after a build.

@DGaffney DGaffney merged commit 6ddc2ed into develop Jul 24, 2023
2 checks passed
@DGaffney DGaffney deleted the cv2-3525-remove-chromaprint-local branch July 24, 2023 20:11
@skyemeedan skyemeedan mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants